jlalwani-amazon opened a new pull request, #141: URL: https://github.com/apache/flink-connector-elasticsearch/pull/141
## What is the purpose of the change Remove dead code in `RowElasticsearchEmitter`. In the `else` branch, `key` is always `null` (the `if` checks `key != null`), so `.id(key)` is `.id(null)` — a no-op that confuses readers. *JIRA: [FLINK-28109](https://issues.apache.org/jira/browse/FLINK-28109)* ## Brief change log - Remove `.id(key)` from `IndexRequest` in the else branch of `processUpsert()` (1 line) ## Does this pull request potentially affect one of the following parts? - Dependencies: **no** - The public API: **no** - The serializers: **no** - The runtime per-record code paths: **no** (no behavioral change, `.id(null)` was a no-op) - Anything that affects deployment or recovery: **no** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
