spuru9 commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359382691
As per Claude
NoticeFileChecker only scans module `META-INF/NOTICE` files. At
`tools/ci/flink-ci-tools/.../NoticeFileChecker.java:358-368`, findNoticeFiles()
walks the tree and keeps only paths ending in `…/resources/META-INF/NOTICE` —
i.e., per-module shaded-jar NOTICE files inside the Maven build.
NOTICE-binary_PREAMBLE.txt doesn't match that pattern. It lives under
tools/releasing/, isn't inside any module's `src/main/resources/META-INF/`, and
is used by the release tooling (collect_license_files.sh etc.) to hand-assemble
the binary-release NOTICE — not by CI. So the checker never looks at it, and a
stale version doesn't fail the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
