featzhang commented on PR #34: URL: https://github.com/apache/flink-connector-http/pull/34#issuecomment-4365920808
Thanks for the review. Pushed a rebuilt commit that squashes the history into a single clean commit on top of current `main` and addresses the outstanding feedback: - Default value is `flink-connector-http` (per your earlier comment on the `getindata` identifier). - Conflict with `http.sink.header.User-Agent` / `http.source.lookup.header.User-Agent` is now rejected at table creation time with a clear `IllegalArgumentException`, instead of silently letting one value win. - Rebased onto `main`, so both the new `USER_AGENT` option and the `FLINK-HTTP-3` map-type header options (`SINK_HEADERS`, `SOURCE_LOOKUP_HEADERS`) are registered in the factories side by side — no regression on FLINK-HTTP-3. - Fixed the Java 17 CI failure (missing `assertThatThrownBy` static import in the two new tests). - Added documentation: a row in the lookup and sink options tables plus a short `User-Agent` subsection with an example DDL in both `content` and `content.zh`. Local `mvn spotless:check` and `mvn test -pl flink-connector-http` are green (396 tests, 0 failures, 0 errors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
