ctrlaltdilj commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3951314511
##########
flink-filesystems/flink-s3-fs-base/src/test/java/org/apache/flink/fs/s3/common/HAApplicationRunOnSeaweedFsS3StoreITCase.java:
##########
@@ -87,7 +88,13 @@ private static List<S3ObjectSummary>
getObjectsFromApplicationResultStore() {
.listObjects(
getSeaweedFsContainer().getDefaultBucketName(),
createSubPath(CLUSTER_ID,
APPLICATION_RESULT_STORE_FOLDER))
- .getObjectSummaries();
+ .getObjectSummaries()
+ .stream()
+ // S3A keeps zero-byte directory markers since Hadoop 3.4
+ // (fs.s3a.directory.marker.retention defaults to "keep");
only actual
+ // ApplicationResultStore entries are relevant for the
assertions.
+ .filter(summary -> !summary.getKey().endsWith("/"))
+ .collect(Collectors.toList());
Review Comment:
good call, fixed, so we now set s3.directory.marker.retention: delete in the
test config instead and dropped the listing filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
