tchivs commented on code in PR #4530:
URL: https://github.com/apache/flink-cdc/pull/4530#discussion_r4140722129
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/data/writer/AbstractBinaryWriter.java:
##########
@@ -236,7 +236,11 @@ public void writeDate(int pos, DateData value) {
@Override
public void writeTime(int pos, TimeData value, int precision) {
- writeInt(pos, value.toMillisOfDay());
+ if (precision <= 3) {
+ writeInt(pos, value.toMillisOfDay());
+ } else {
+ writeLong(pos, Long.MIN_VALUE | value.toNanoOfDay());
+ }
Review Comment:
Addressed and agreed: writeTime now stores the same eight-byte value as
writeTimestamp and ignores the precision argument. Same for the array writer's
null setter and calculateFixLengthPartSize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
