spuru9 commented on code in PR #220:
URL:
https://github.com/apache/flink-connector-jdbc/pull/220#discussion_r4368322220
##########
docs/content/docs/connectors/datastream/jdbc.md:
##########
@@ -72,15 +81,79 @@ JdbcSource source = JdbcSourceBuilder.builder()
.setResultSetFetchSize(...)
.setConnectionProvider(...)
.build();
+```
+
+`setSplitter` describes the query and how it is divided into splits, and is
the only required way to
+define what the source reads. The older `setSql` /
`setJdbcParameterValuesProvider` pair is
+deprecated in favour of it; see [Deprecated query API](#deprecated-query-api).
Setting both a
+splitter and a query fails at `build()` time.
+### SplitterEnumerator
+
+A `SplitterEnumerator` produces the `JdbcSourceSplit`s that the readers
execute, and decides whether
+the source is bounded or continuously unbounded.
+
+#### PreparedSplitterEnumerator
+
+`PreparedSplitterEnumerator` builds bounded splits from a query template. With
no parameters the
+query becomes a single split:
Review Comment:
Fixed as #243 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
