bharathgunapati commented on code in PR #57: URL: https://github.com/apache/flink-connector-http/pull/57#discussion_r4371720745
########## docs/content/docs/connectors/table/http.md: ########## @@ -633,6 +634,22 @@ If either legacy property is set together with `http.sink.success-codes` or `htt - `http.sink.retry-codes` (default `500,503,504`) for retryable responses - `http.sink.ignored-response-codes` for responses that should be treated as successful without retrying +### Retries and handling errors (Sink) +Retries are disabled by default: `http.sink.max-retries` defaults to `0`, so the first failed request fails the job. + +When `http.sink.max-retries` is greater than `0`, the sink retries requests that fail before a response is received (for +example, connection errors) and responses whose status code is listed in `http.sink.retry-codes`. The delay between Review Comment: Good catch. Added a paragraph on all four pages: with the legacy `http.sink.error.code` / `http.sink.error.code.exclude` properties no status code is retried, a code in the error list fails the job, every other code is success, and only requests that fail before a response is retried. That matches `HttpSinkResponseClassifier`, which returns only SUCCESS or FATAL_FAILURE on the legacy path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
