raminqaf commented on code in PR #29580:
URL: https://github.com/apache/flink/pull/29580#discussion_r4374706257


##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariant.java:
##########
@@ -362,6 +365,8 @@ private BinaryVariant getFieldByKey(String key) {
                             // handle the case where `low + high` overflows 
int.
                             int mid = (low + high) >>> 1;
                             int id = readUnsigned(value, idStart + idSize * 
mid, idSize);
+                            // Compare decoded Strings here. The builder sorts 
fields by
+                            // String.compareTo, which is not UTF-8 byte order.

Review Comment:
   This will be fixed in: https://issues.apache.org/jira/browse/FLINK-41180



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to