gustavodemorais commented on code in PR #29558:
URL: https://github.com/apache/flink/pull/29558#discussion_r4378290226
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/interval/IntervalJoinFunction.java:
##########
@@ -88,6 +85,15 @@ public TypeInformation<RowData> getProducedType() {
}
public void setJoinKey(RowData currentKey) {
- this.joinKey = (NullAwareGetters) currentKey;
+ // the key is always BinaryRowData
+ this.joinKey = (BinaryRowData) currentKey;
Review Comment:
nit: `NullAwareJoinHelper#shouldFilter` only uses `anyNull`, so it could
take a `NullAwareGetters` instead of `BinaryRowData`. Then `joinKey` can keep
its original `NullAwareGetters` type and cast here, and the existing callers
still compile since `BinaryRowData` implements `NullAwareGetters`:
```java
public static boolean shouldFilter(
boolean nullSafe, boolean filterAllNulls, int[] nullFilterKeys,
NullAwareGetters key) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
