spuru9 commented on code in PR #29609:
URL: https://github.com/apache/flink/pull/29609#discussion_r4380041668
##########
docs/content/docs/connectors/datastream/overview.md:
##########
@@ -70,15 +73,29 @@ If you need to run examples locally, make sure that the
flink-connector-base dep
provided and can be found in your own classpath.
{{< /hint >}}
-## Connectors in Apache Bahir
+## Flink CDC
+
+[Flink CDC](https://nightlies.apache.org/flink/flink-cdc-docs-stable/) is an
Apache Flink sub-project with its own releases. Its source connectors read
+changes directly from databases such as MySQL, PostgreSQL, Oracle, SQL Server,
MongoDB and Db2. See
+the [Flink CDC
sources](https://nightlies.apache.org/flink/flink-cdc-docs-stable/docs/connectors/flink-sources/overview/)
for the supported databases and Flink versions.
+
+## Fault Tolerance Guarantees
+
+Flink recovers from failures by restarting from the last [checkpoint]({{< ref
"docs/dev/datastream/fault-tolerance/checkpointing" >}}). For exactly-once
+results, the source must be able to rewind to the position stored in the
checkpoint, and the sink
+must take part in checkpointing, either by committing its writes
transactionally or by writing
+idempotently. See [Stateful Stream Processing]({{< ref
"docs/concepts/stateful-stream-processing" >}}#checkpointing) for how
checkpoints work.
Review Comment:
nit: The SQL overview says checkpointing is off by default, and DataStream
readers need that just as much. Same on the zh page (L80–83).
```suggestion
Flink recovers from failures by restarting from the last [checkpoint]({{<
ref "docs/dev/datastream/fault-tolerance/checkpointing" >}}). Checkpointing is
disabled by default. For exactly-once results, the source must be able to
rewind to the position
stored in the checkpoint, and the sink must take part in checkpointing,
either by committing its
writes transactionally or by writing idempotently. See [Stateful Stream
Processing]({{< ref "docs/concepts/stateful-stream-processing"
>}}#checkpointing) for how checkpoints work.
```
##########
docs/content/docs/connectors/other-projects/overview.md:
##########
@@ -0,0 +1,49 @@
+---
+title: Overview
+weight: 1
+type: docs
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Integrations Maintained by Other Projects
+
+The projects listed here maintain their own Flink integration. Each
integration is developed,
+released and supported by that project's community, not by the Apache Flink
community. That
+project's documentation covers which artifacts to use and how to configure it.
Report issues and ask
+questions in that project's channels.
+
+A project is listed here when it is an Apache Software Foundation project and
has released a Flink
+integration for a Flink version that is still supported.
Review Comment:
minor: As written, this rule also covers Apache Pinot: the released
`pinot-flink-connector` 1.5.x builds against Flink 1.20, and 1.6.0 (now at RC)
moves to Flink 2.3. Should Pinot be added, or the rule tightened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
