jagath25 commented on code in PR #29473:
URL: https://github.com/apache/flink/pull/29473#discussion_r4380106980
##########
flink-clients/src/main/java/org/apache/flink/client/deployment/application/PackagedProgramApplication.java:
##########
@@ -368,6 +378,20 @@ public void cancel() {
public void dispose() {
isDisposing = true;
cancelFutures();
+ closeProgram();
Review Comment:
Thanks for the review, and for reproducing the leadership-grant issue. I’ve
reduced the PR to the first commit only, which fixes FLINK-35376 (duplicate
PackagedProgram in applyToConfiguration), and removed the Copilot
Co-authored-by trailers. The run-application ownership/close change is dropped
from this PR; I’ll open a separate ticket for it and take your point about
ApplicationDispatcherGatewayServiceFactory reusing the program across
leadership grants into account there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
