MartijnVisser commented on code in PR #29423:
URL: https://github.com/apache/flink/pull/29423#discussion_r4390286359
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdWindowProperties.scala:
##########
@@ -435,10 +436,16 @@ class FlinkRelMdWindowProperties private extends
MetadataHandler[FlinkMetadata.W
def inferWindowPropertyAfterWindowJoin(
leftWindowProperty: ImmutableBitSet,
rightWindowProperty: ImmutableBitSet): ImmutableBitSet = {
+ // window columns on an outer join's null-generating side become
nullable, so they are no
+ // longer valid window properties
+ val preservedLeft =
+ if (joinType.generatesNullsOnLeft) ImmutableBitSet.of() else
leftWindowProperty
+ val preservedRight =
Review Comment:
Discussed offline and we agreed that there's no other way to get this done.
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
