gyfora commented on code in PR #1227:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1227#discussion_r4401743432
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -715,6 +715,14 @@ public static String operatorConfigKey(String key) {
.withDescription(
"Allowed max time between spec update and
reconciliation for canary resources.");
+ @Documentation.Section(SECTION_ADVANCED_STARTUP)
+ public static final ConfigOption<Integer>
CANARY_RESOURCE_RETRY_MAX_ATTEMPTS =
+ operatorConfig("health.canary.resource.retry.max.attempts")
+ .intType()
+ .defaultValue(3)
Review Comment:
I would really prefer to hardcode this to some reasonable number (3 sounds
good ) and not make it configurable. feels kind of useless config, lets save
the space :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
