[
https://issues.apache.org/jira/browse/FLINK-40793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133653#comment-18133653
]
sepuri sai krishna commented on FLINK-40793:
--------------------------------------------
[~martijnvisser] both of these are covered by the patch already in PR #29278,
no update needed.
{{jobStatusIsRestartingIfOneVertexIsWaitingForRestart}} and
{{testStartCheckpointOnlyAfterVertexWithBlockingEdgeFinished}} both call
{{createSchedulerAndStartScheduling}}. All four of its overloads funnel into
the one that calls {{createSchedulerBuilder}}, and all three
{{createScheduler}} overloads call it too, so every scheduler in the class is
built through that one method, which is the one the patch changes.
I also checked the full list on this ticket against master. All ten reported
methods reach {{createSchedulerBuilder}}, counting
{{testJobStatusHookWithJobCanceled}} and {{testJobStatusHookWithJobFinished}}
through {{commonJobStatusHookTest}}. The only place that builds a scheduler
directly is still {{testCheckpointCleanerIsClosedAfterCheckpointServices}},
which has not appeared in any of the runs.
The patch still applies to current master unchanged, and I have rebased the PR
onto it so CI runs again. The green build on it was from 27 September.
> DefaultSchedulerTest is unstable across many test methods
> ---------------------------------------------------------
>
> Key: FLINK-40793
> URL: https://issues.apache.org/jira/browse/FLINK-40793
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 2.2.2, 2.3.1, 2.4.0
> Reporter: sepuri sai krishna
> Assignee: sepuri sai krishna
> Priority: Critical
> Labels: pull-request-available, test-stability
>
> DefaultSchedulerTest failed 17 times in the 90 days to 2026-09-15, in 11
> different test methods, on all core CI profiles (Java 11, 17, 21, Hadoop,
> AdaptiveScheduler). It is not limited to master: the most recent two are
> 2026-09-14 on master and 2026-09-10 on release-2.3.
> Recent runs:
> * https://github.com/apache/flink/actions/runs/34798011374/job/103837976051
> master, testExceptionHistoryWithRestartableFailure
> * https://github.com/apache/flink/actions/runs/34427845031/job/102726173515
> release-2.3, testExceptionHistoryWithRestartableFailure
> * https://github.com/apache/flink/actions/runs/33866786819/job/101007980019
> testExceptionHistoryConcurrentRestart
> * https://github.com/apache/flink/actions/runs/33349433782/job/99360730245
> testJobStatusHookWithJobCanceled
> * https://github.com/apache/flink/actions/runs/32136151763/job/95710148170
> testExceptionHistoryWithGlobalFailOver
> * https://github.com/apache/flink/actions/runs/31662007213/job/94339220821
> testJobStatusHookWithJobFinished
> * https://github.com/apache/flink/actions/runs/30418270959/job/90470994165
> testStartCheckpointOnlyAfterVertexWithBlockingEdgeFinished
> Other failing methods: skipDeploymentIfVertexVersionOutdated,
> testDeploymentWaitForProducedPartitionRegistration,
> failGlobalWhenRestoringStateFails,
> jobStatusIsRestartingIfOneVertexIsWaitingForRestart,
> abortPendingCheckpointsWhenRestartingTasks.
> {code}
> [ERROR]
> org.apache.flink.runtime.scheduler.DefaultSchedulerTest.testJobStatusHookWithJobCanceled
> -- Time elapsed: 0.014 s <<< FAILURE!
> org.opentest4j.AssertionFailedError:
> expected: CANCELED
> but was: FAILED
> at
> org.apache.flink.runtime.scheduler.DefaultSchedulerTest.commonJobStatusHookTest(DefaultSchedulerTest.java:1933)
> at
> org.apache.flink.runtime.scheduler.DefaultSchedulerTest.testJobStatusHookWithJobCanceled(DefaultSchedulerTest.java:1818)
> {code}
> {code}
> [ERROR]
> org.apache.flink.runtime.scheduler.DefaultSchedulerTest.testStartCheckpointOnlyAfterVertexWithBlockingEdgeFinished
> -- Time elapsed: 0.026 s <<< ERROR!
> java.lang.IllegalStateException
> at
> org.apache.flink.util.Preconditions.checkState(Preconditions.java:177)
> at
> org.apache.flink.runtime.scheduler.DefaultSchedulerTest.transitionToRunning(DefaultSchedulerTest.java:2362)
> at
> org.apache.flink.runtime.scheduler.DefaultSchedulerTest.testStartCheckpointOnlyAfterVertexWithBlockingEdgeFinished(DefaultSchedulerTest.java:1877)
> {code}
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
