ykisana commented on PR #29641: URL: https://github.com/apache/flink/pull/29641#issuecomment-6463630431
> The PR itself looks good. One finding is that the timestamp precision issue from the same backport still remains: `test_empty_to_pandas_with_timestamps` and `test_to_pandas_with_fixed_offset_timezones` fail in both batch and streaming modes. Empty results use datetime64[ms] instead of datetime64[s] for TIMESTAMP(0), and microseconds instead of milliseconds for TIMESTAMP_LTZ(3). We may need to preserve logical_type.getPrecision() in both timestamp branches of _from_java_data_type() and add a precision round-trip test. This would address the remaining failures after the allow_nested fix. Nit: I'd update PR description to include the precision change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
