fresh-borzoni commented on PR #29653: URL: https://github.com/apache/flink/pull/29653#issuecomment-6467679635
@xuyangzhong @gustavodemorais Hi! This replaces #27372, which was auto-closed as stale. It's rebased on current master. @xuyangzhong, your earlier comments are addressed: the equivalences no longer go into `getUpsertKeys`. They're resolved on demand at the sink against the sink PK, so the key set never grows. @gustavodemorais, tagging you because this touches canUpsertKeysWithImmutableColsSatisfyPk next to your FLINK-40447 change. This matters more now that table.exec.sink.require-on-conflict defaults to true (since 2.3). A join like src1(pk a1) JOIN src2(pk a2, b2) ON a1 = a2 into a sink with PK (a1, b2) now fails planning with "upsert key differs from the primary key... specify ON CONFLICT", even though the key is covered. We hit this with parent/child CDC joins, where it also blocks delta join until your reorder as was shown in #27372 Would appreciate a review 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
