rionmonster commented on PR #29570: URL: https://github.com/apache/flink/pull/29570#issuecomment-6514516891
Thanks @gustavodemorais, agreed, and no worries. I went ahead and dropped the DELETE handling (at least of records that aren't stored) as well of a bunch of other bits/cases that can move to the regular join work in FLINK-41258. Also given the extent of the changes, I squashed the history down into four commits to hopefully make things a little easier to grok. The code should roughly be the same as the version that you reviewer earlier sans what we just ripped out. There's two other things that still lingered, but I can happily drop if you don't think they are needed (per Claude): - `removeMatch` and the right accumulate path treat a count `<= 0` as no match, so a count never goes negative. It's just a comparison, without state access, and it's its own commit, so it's easy to drop. - A replaced left row is retracted based on its stored number of matches, instead of a second scan of the right state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
