slachiewicz commented on code in PR #307:
URL:
https://github.com/apache/maven-gh-actions-shared/pull/307#discussion_r3795929207
##########
.github/workflows/maven-verify.yml:
##########
@@ -342,6 +366,19 @@ jobs:
path: |
target/staging/**
+ # The build above runs current Maven, so nothing so far exercises the
version the project
+ # declares in <prerequisites>. Compiling both source roots against that
API level catches
+ # drift for a fraction of the cost of a second test run.
+ #
+ # clean is not optional: target/ is warm from the build and site steps,
and without it the
+ # compiler reports "Nothing to compile - all classes are up to date" and
this passes green
+ # having compiled nothing. It is therefore not exposed as an input.
+ #
+ # Placed after Upload Maven Site because that clean would discard
target/staging.
+ - name: Verify compatibility with Maven ${{ env.BASELINE_MAVEN }}
+ if: inputs.ff-baseline-run
+ run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args
}} "-DmavenVersion=${{ env.BASELINE_MAVEN }}" clean test-compile
+
Review Comment:
Yeap may be better idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
