slachiewicz opened a new pull request, #927:
URL: https://github.com/apache/maven-wagon/pull/927
Backport of `a8cafa27` from master, scoped the same way it was scoped there.
Only tests that do **not** extend the bases published from
`wagon-provider-test` move. Those bases —
`WagonTestCase`, `StreamingWagonTestCase`, `HttpWagonTestCase`,
`CommandExecutorTestCase` — ship in
`src/main/java`, so external providers extend them and inherit their test
methods by the `testXxx()`
naming convention: 14, +6, +39 and 3 respectively. Moving them to `@Test`
would leave any consumer
still on JUnit 4 running none of those inherited tests, with no compile
error and a green build. They
are still on `PlexusTestCase` on master too, so this branch does not lead
master there.
Following master file by file: of the twelve candidates here, master
migrated six and left six alone.
This migrates the same six. Four were byte-identical to master's
pre-migration state, so master's
reviewed version is taken verbatim; `FileKnownHostsProviderTest` and
`webdav/HttpClientWagonTest` had
drifted and were ported, keeping this branch's `FileUtils.fileRead` rather
than master's
`Files.readAllBytes`.
`wagon-webdav-jackrabbit` keeps `junit` and gains `junit-vintage-engine`
alongside `junit-jupiter`,
matching master: it still has a test inheriting from `HttpWagonTestCase`,
and surefire provisions the
jupiter engine but not the vintage one. No versions are needed —
`maven-parent` 49 imports `junit-bom`.
One behavioural detail worth a look:
`HttpClientWagonTest.testSetPreemptiveAuthParamViaConfig` carried
`@Ignore("not sure how to test this")`, but `@Ignore` does nothing on a
`junit.framework.TestCase`
subclass — the surefire report confirms that test ran and passed. It is
dropped rather than translated,
because `@Disabled` would have silently stopped running it.
Verified: `mvn test` before and after on all three touched modules —
wagon-http-shared 12 → 12,
wagon-ssh-common 7 → 7, wagon-webdav-jackrabbit 295 → 295, zero skipped,
zero failures, zero errors
throughout. As a negative control, a deliberately broken assertion in a
migrated file produced
`failures="1"` and a non-zero build, confirming the migrated tests are
really executed rather than
collected as an empty set.
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
