slachiewicz opened a new pull request, #932:
URL: https://github.com/apache/maven-wagon/pull/932
Backport of #930. This branch's three copies were byte-identical to master's
before its migration, so
master's result is taken verbatim.
No new dependency: the container was only supplying `Wagon.ROLE`, which is
`HttpWagon`, and
`AbstractHttpClientWagon` declares no injected collaborators.
Two details worth a look, same as on master:
- The base lifecycle method is renamed `startTestServer`. Left as `setUp()`,
the subclasses' own
`setUp()` would override it and JUnit 5 would run only the override, so
the Jetty server would never
be created. With distinct names JUnit 5 runs the superclass `@BeforeEach`
first in its own right and
the subclasses drop their `super.setUp()` call.
- `getName()` came from `junit.framework.TestCase` and feeds six
`FileTestUtils.createUniqueFile` call
sites; it now comes from an injected `TestInfo`, leaving those unchanged.
Verified: `mvn test` on `wagon-http`, counting `<testcase>` elements per
class — 295 before and after,
2 skipped in both, zero failures. `HttpWagonErrorTest` stays at 5 and
`HttpWagonTimeoutTest` at 4,
which is what shows the base setup still runs.
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
