slachiewicz commented on PR #817: URL: https://github.com/apache/maven-wagon/pull/817#issuecomment-5333413576
The fix is right: `File.getParentFile()` returns null for a bare relative filename, which is exactly what `gpg:sign-and-deploy-file` passes through `-Dfiles`, so `setWorkingDirectory` got an NPE instead of a directory. Two things before this can land. The checks here ran in September 2025 against a `wagon-3.x` that has since moved a long way, so they say nothing about the current base — this needs a rebase and a fresh run. And the change has no test; `ScpExternalWagon` is awkward to cover, but a case asserting the working directory for a parentless `localFile` would keep it from regressing. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
