dchaudhari7177 opened a new pull request, #1013:
URL: https://github.com/apache/maven-archetype/pull/1013

   Closes #1012.
   
   Removes three things that only made sense together:
   
   1. `org.mortbay.jetty:maven-jetty-plugin:6.1.26` from the root 
`pluginManagement`
   2. the `archetype-samples/` tree (13 files)
   3. the now-dead `<exclude>archetype-samples/**</exclude>` RAT entry, which 
would otherwise match nothing
   
   ```
   14 files changed, 321 deletions(-)
   ```
   
   ## Confirmed the claims before deleting
   
   - `archetype-samples` is **not** among the four `<module>` entries 
(`archetype-models`, `archetype-common`, `maven-archetype-plugin`, 
`archetype-packaging`)
   - outside the tree itself, the only reference in the whole repository was 
the RAT exclude
   - its parent is 
`org.apache.maven.archetypes:archetype-samples:2.0-alpha-5-SNAPSHOT` — never 
released, so the tree could not build regardless
   - `jetty` / `mortbay` appeared only in the root POM and 
`archetype-samples/webapp/pom.xml`
   
   After the change, `git grep` over the committed tree finds **no** remaining 
reference to `archetype-samples`, `mortbay` or `jetty`.
   
   ## Verification
   
   Maven 3.9.9, JDK 21:
   
   | command | result |
   |---|---|
   | `mvn -N validate` | **BUILD SUCCESS** |
   | `mvn -N apache-rat:check` | **BUILD SUCCESS** — Unapproved: 0, unknown: 0, 
approved: 19 |
   
   The RAT run matters here specifically: removing an exclude can newly expose 
files, and it does not — 0 unapproved.
   
   A full reactor `mvn validate` fails in `enforce-bytecode-version` on 
`archetype-common`. I checked that against a pristine `master` and it fails 
**identically there**, so it is a pre-existing issue in my local environment 
and not something this PR touches. CI will be the real signal for the full 
build.
   
   ## Scope note
   
   The released archetypes live in `apache/maven-archetypes`, so no generated 
project inherits any of this. As the issue notes, the only theoretical reach is 
anything declaring this root POM as a parent, which outside this repository is 
nobody.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to