Jamison929611 commented on PR #2060:
URL: https://github.com/apache/maven-resolver/pull/2060#issuecomment-5354199269
Addressed in 56e23235.
I verified the Maven execution you linked: it intentionally keeps
api/maven-api-core as the positional configuration source root, while its
aggregate Javadocs cover the wider reactor.
CollectConfiguration now exposes a repeatable --internal-javadoc-source-tree
option. Configuration declarations are still collected only below the
positional root; source roots used to validate aggregate Javadoc links are
discovered independently from the configured tree(s). If the option is omitted,
it defaults to the positional root, preserving the existing Resolver invocation.
For the Maven execution, the existing positional argument can remain
unchanged and the page execution can add:
~~~xml
<argument>--internal-javadoc-source-tree=${project.basedir}</argument>
~~~
The regression test now invokes the public CLI with a narrow
configuration-module positional root and a separate reactor-wide source tree,
rather than placing both modules below the positional root. The full
ConfigurationCollectorDocletTest suite passes (9/9), the 26-module package
build succeeds, and Resolver's real generated configuration page still contains
the HttpVersion Javadoc link and the configuration anchor using the default
behavior.
@kwin, could you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
