elharo commented on code in PR #1004:
URL: https://github.com/apache/maven-enforcer/pull/1004#discussion_r3825426464
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BanDistributionManagement.java:
##########
@@ -72,12 +72,23 @@ public void execute() throws EnforcerRuleException {
getLog().debug("We are in the root of the execution and we
have a parent.");
DistributionManagementCheck check = new
DistributionManagementCheck(project);
- check.execute(isAllowRepository(),
isAllowSnapshotRepository(), isAllowSite());
+ executeCheck(check);
}
} else {
getLog().debug("We are in a deeper level.");
DistributionManagementCheck check = new
DistributionManagementCheck(project);
+ executeCheck(check);
+ }
+ }
+
+ private void executeCheck(DistributionManagementCheck check) throws
EnforcerRuleException {
Review Comment:
Not for this PR but as I look at this now I realize we've designed this
completely wrong. There shouldn't be exceptions here at all. Bleah.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
