elharo commented on code in PR #1002:
URL: https://github.com/apache/maven-enforcer/pull/1002#discussion_r3813230533
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/RequireUpperBoundDeps.java:
##########
@@ -223,8 +226,11 @@ public boolean visitEnter(DependencyNode node) {
DependencyNodeHopCountPair pair = new
DependencyNodeHopCountPair(node, this);
String key = pair.constructKey();
- if (includes != null && !includes.isEmpty() &&
!includes.contains(key)) {
- return true;
+ if (includesMatcher != null) {
Review Comment:
what if instead of a null check we used a matcher that matches everything as
the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
