elharo opened a new pull request, #164:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/164
Fixes #147
## Problem
`processArchive()` wraps the `nonProxyHosts` value in literal quote
characters when constructing `-J-D` arguments for the JVM:
```java
additionalArguments.add("-J-Dhttp.nonProxyHosts=\""
+ this.settings.getActiveProxy().getNonProxyHosts() + "\"");
```
These literal `\"` characters are passed to the JVM verbatim, so the system
property `http.nonProxyHosts` is set to `"localhost|*.example.com"` (with
quotes) instead of `localhost|*.example.com`. This breaks non-proxy host
matching.
## Fix
Remove the `\"` quoting around the nonProxyHosts value in
`AbstractJarsignerMojo.java:526-531`.
## Test
Added `testNonProxyHostsNoQuotes` to `JarsignerSignMojoTest` that configures
a proxy with `nonProxyHosts=localhost|*.example.com` and asserts the resulting
`-J-D` arguments contain the value without literal quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
