elharo commented on code in PR #157:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/157#discussion_r3838454440
##########
src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:
##########
@@ -347,6 +348,25 @@ private List<File> findJarfiles() throws
MojoExecutionException {
return archives;
}
+ /**
+ * Joins a string array with commas, skipping null elements.
+ *
+ * @param strings the strings to join
+ * @return the comma-separated string, or {@code null} if the input is
{@code null}
+ */
+ private static String joinStrings(String[] strings) {
+ if (strings == null) {
+ return null;
+ }
+ StringJoiner joiner = new StringJoiner(",");
Review Comment:
This is unnecessary. includes and excludes might be null but they cannot
have null elements and we do not need to check for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
