gnodet commented on PR #12755:
URL: https://github.com/apache/maven/pull/12755#issuecomment-5388689759

   Thanks for the contribution! However, the work requested in MNG-7575 is 
actually **already done** in the current model.
   
   The `requiresReports` field is scoped to bare `<version>1.0.0</version>` 
(with the comment `<!-- no longer part of 1.1.0 -->`), which means Modello 
already **excludes** it from the 1.1.0 model and every version after it. The 
current model version generated from this `.mdo` is `2.0.0` (configured in the 
POM), so this field has zero effect on the built artifact.
   
   The field definition remaining in `plugin.mdo` serves as **historical 
documentation of the 1.0.0 model schema** — similar to how other legacy fields 
and entire classes (`Requirement`, `Dependency`) are kept with 
`<version>1.0.0/1.1.0</version>` to preserve the full schema history. Removing 
it would mean the `.mdo` file no longer fully describes the 1.0.0 model, which 
could be needed if someone ever wants to regenerate it.
   
   Closing as the removal doesn't fix anything that isn't already fixed, and it 
loses historical completeness.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to