desruisseaux commented on PR #508: URL: https://github.com/apache/maven-jar-plugin/pull/508#issuecomment-5394376902
@seregamorph, @hboutemy: I'm almost done in fixing the issue raised last week, with the help of @ascheman commits (thanks!). I have made one change which I suspect will be highly controversial. If strictly reproducible builds has been requested, the JDK version in the `Created-By` attribute is replaced by `"Maven JAR plugin on unspecified JDK"`. The _"on unspecified JDK"_ is my addition. The intend is to remind users that strictly reproducible builds is causing harm here, and encouraging them to switch to semantically reproducible builds if Maven provides a way to run this verification easily. However, I'm not strongly attached to this addition. If there are objections, I will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
