elharo commented on code in PR #422: URL: https://github.com/apache/maven-help-plugin/pull/422#discussion_r3843498662
########## src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java: ########## Review Comment: I don't think anything is written if output is null. Given that there's no need for a fallback. Just set encoding to project.getModel().getModelEncoding() in line 110. In fact, it looks like if output is null a lot of code here could be skipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
