elharo commented on code in PR #843:
URL:
https://github.com/apache/maven-shade-plugin/pull/843#discussion_r3848166426
##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -1260,6 +1269,23 @@ private void
rewriteDependencyReducedPomIfWeHaveReduction(
}
}
+ /**
+ * Keep a local relativePath only when it really points at the parent POM.
+ * Otherwise Maven 4 treats the default {@code ..} as the parent and
reports
+ * a cycle against a sibling POM that happens to share the same parent GAV.
+ */
+ static boolean parentFileIsTheConfiguredRelativePath(File configured, File
actual) {
Review Comment:
This method name has to be simplified.and should probably be private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
