gnodet commented on PR #12694: URL: https://github.com/apache/maven/pull/12694#issuecomment-5450880020
## Review feedback addressed All 8 review comments from @gnodet and @ascheman have been addressed in the latest force-push. Summary of changes: ### Bug fixes - **`sequenceNumber()` javadoc** — corrected from "always non-negative" to "or `-1` if unavailable" - **`warn(Supplier, Throwable)` regression** — was calling `logger.info()` instead of `logger.warn()` (added regression test) ### Design improvements - **`MavenJulHandler` simplified** — removed `formatForConsole()` entirely; all JUL events now always route through SLF4J so `MavenSimpleLogger` produces a consistent `formattedMessage` regardless of origin - **`Log.trace()` backward compatibility** — all 6 trace methods changed from `abstract` to `default` implementations (no-ops) to prevent `AbstractMethodError` for existing third-party `Log` implementors - **StackWalker gated** — `withMetadata()` only walks the stack when `ProjectBuildLogAppender.hasReportCapture()` is true; normal builds pay zero StackWalker cost - **Fork-aware mojoId** — added `FORKING_MOJO_ID` ThreadLocal mirroring `FORKING_PROJECT_ID`; `forkStarted()`/`forkSucceeded()`/`forkFailed()` save and restore mojo context - **Throwable rendering unified** — `MavenSimpleLogger.write()` now reuses the existing `writeThrowable()` method; removed the duplicate `appendFormattedThrowable()`/`appendStackTrace()` methods - **Null `loggerName` guard** — `MavenJulHandler.publish()` now handles `null` logger names per JUL spec ### Tests added - `DefaultLogTest` (4 tests): warn/supplier regression, metadata lifecycle, trace delegation, trace no-op - `MavenJulHandlerTest` (10 tests): parameterized JUL→SLF4J level mapping, FINEST→TRACE, CONFIG→INFO, metadata null check All 6 downstream PRs (#12695, #12697, #12698, #12699, #12702, #12714) have been rebased onto the updated commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
