[
https://issues.apache.org/jira/browse/IMPALA-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464003#comment-16464003
]
ASF subversion and git services commented on IMPALA-6507:
---------------------------------------------------------
Commit 2f6bd64b5f7d063ff3e22fb15cc729b4cf03681a in impala's branch
refs/heads/master from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=2f6bd64 ]
IMPALA-6507: remove --disable_mem_pools debug feature
Save some maintenance overhead by simplifying memory
allocation code paths. ASAN poisoning provides the same general
functionality and is on by default.
Change-Id: I78062569448fed0d076ec506eb8e097ce44d9fea
Reviewed-on: http://gerrit.cloudera.org:8080/10294
Reviewed-by: Dan Hecht <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Consider removing --disable_mem_pools debugging feature
> -------------------------------------------------------
>
> Key: IMPALA-6507
> URL: https://issues.apache.org/jira/browse/IMPALA-6507
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.11.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Labels: resource-management
>
> We should consider removing support for the --disable_mem_pools feature. It
> was originally somewhat useful for debugging memory-related issues where
> memory pooling could limit the effectiveness of ASAN's checks. However, now
> we use ASAN's poisoning in all cases, which provides most of the same
> coverage and is used by default with ASAN.
> We don't routinely test --disable_mem_pools so we should consider removing it
> to save the burden of maintaining these extra code paths.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
