[ 
https://issues.apache.org/jira/browse/IMPALA-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476583#comment-16476583
 ] 

Tim Armstrong commented on IMPALA-6969:
---------------------------------------

I prototyped a fix of this. It touches the same code as the async queuing, so I 
won't finish it off until that is merged.

> Profile doesn't include the reason that a query couldn't be dequeued from 
> admission controller
> ----------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-6969
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6969
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 3.0, Impala 2.12.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>              Labels: admission-control, observability
>
> I noticed this while playing around on a local minicluster with AC enabled.
> The admission controller adds the reason for initial queuing to the profile, 
> but does not expose why the query couldn't execute when it got to the head of 
> the line. E.g. if it was initially queued because the queue was non-empty but 
> then couldn't execute once it got to the head of the line because of memory.
> {noformat}
>     Request Pool: root.queueA
>     Admission result: Admitted (queued)
>     Admission queue details: waited 1130 ms, reason: queue is not empty (size 
> 4); queued queries are executed first
> {noformat}
> We should still include the initial reason for queuing, but also include the 
> most reason for queuing once it got to the head of the line. It's probably 
> most useful to keep the profile updated with the latest reason at all times 
> (since the details can change while the query is at the head of the line).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to