[
https://issues.apache.org/jira/browse/IMPALA-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480166#comment-16480166
]
ASF subversion and git services commented on IMPALA-7030:
---------------------------------------------------------
Commit c1c122a10177920903009420d2faac673d867c4b in impala's branch
refs/heads/master from [~dhecht]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=c1c122a ]
IMPALA-5384, part 2: Simplify Coordinator locking and clarify state
The is the final change to clarify and break up the Coordinator's lock.
The state machine for the coordinator is made explicit, distinguishing
between executing state and multiple terminal states. Logic to
transition into a terminal state is centralized in one location and
executes exactly once for each coordinator object.
Derived from a patch for IMPALA_5384 by Marcel Kornacker.
Testing:
- exhaustive functional tests
- stress test on minicluster with memory overcommitment. Verified from
the logs that this exercises all these paths:
- successful queries
- client requested cancellation
- error from exec FInstances RPC
- error reported asynchronously via report status RPC
- eos before backend execution completed
- loop query_test & failure for 12 hours with no dchecks or crashes
(This had previously reproduced IMPALA-7030 and IMPALA-7033 with
the previous version of this change).
Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c
Reviewed-on: http://gerrit.cloudera.org:8080/10440
Reviewed-by: Dan Hecht <dhe...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> crash in impala::PartitionedAggregationNode::ProcessBatchNoGrouping
> --------------------------------------------------------------------
>
> Key: IMPALA-7030
> URL: https://issues.apache.org/jira/browse/IMPALA-7030
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Michael Brown
> Assignee: Dan Hecht
> Priority: Blocker
> Attachments: crash.dump.gz, gdb.out.gz, hs_err_pid1621.log.gz
>
>
> https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/2176/
> {noformat}
> #0 0x00007fc896430428 in __GI_raise (sig=sig@entry=6) at
> ../sysdeps/unix/sysv/linux/raise.c:54
> #1 0x00007fc89643202a in __GI_abort () at abort.c:89
> #2 0x00007fc899379c59 in os::abort(bool) (dump_core=<optimized out>) at
> /build/openjdk-8-wnL82d/openjdk-8-8u171-b11/src/hotspot/src/os/linux/vm/os_linux.cpp:1509
> #3 0x00007fc89952f047 in VMError::report_and_die()
> (this=this@entry=0x7fc7e90287d0) at
> /build/openjdk-8-wnL82d/openjdk-8-8u171-b11/src/hotspot/src/share/vm/utilities/vmError.cpp:1060
> #4 0x00007fc8993836ef in JVM_handle_linux_signal(int, siginfo_t*, void*,
> int) (sig=sig@entry=11, info=info@entry=0x7fc7e9028a70,
> ucVoid=ucVoid@entry=0x7fc7e9028940,
> abort_if_unrecognized=abort_if_unrecognized@entry=1)
> at
> /build/openjdk-8-wnL82d/openjdk-8-8u171-b11/src/hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp:541
> #5 0x00007fc899376d88 in signalHandler(int, siginfo_t*, void*) (sig=11,
> info=0x7fc7e9028a70, uc=0x7fc7e9028940) at
> /build/openjdk-8-wnL82d/openjdk-8-8u171-b11/src/hotspot/src/os/linux/vm/os_linux.cpp:4432
> #6 0x00007fc8967d6390 in <signal handler called> () at
> /lib/x86_64-linux-gnu/libpthread.so.0
> #7 0x00007fc8584ca000 in
> impala::PartitionedAggregationNode::ProcessBatchNoGrouping(impala::RowBatch*)
> [clone .1] ()
> #8 0x0000000002cd5bcf in
> impala::PartitionedAggregationNode::Open(impala::RuntimeState*)
> (this=0x15795200, state=0x14e95d40) at
> /home/ubuntu/Impala/be/src/exec/partitioned-aggregation-node.cc:314
> #9 0x0000000001c94775 in impala::FragmentInstanceState::Open()
> (this=0x1cc19e00) at
> /home/ubuntu/Impala/be/src/runtime/fragment-instance-state.cc:268
> #10 0x0000000001c91faf in impala::FragmentInstanceState::Exec()
> (this=0x1cc19e00) at
> /home/ubuntu/Impala/be/src/runtime/fragment-instance-state.cc:81
> #11 0x0000000001ca175b in
> impala::QueryState::ExecFInstance(impala::FragmentInstanceState*)
> (this=0x3a1f6000, fis=0x1cc19e00) at
> /home/ubuntu/Impala/be/src/runtime/query-state.cc:401
> #12 0x0000000001c9ffce in impala::QueryState::<lambda()>::operator()(void)
> const (__closure=0x7fc7e9029ce8) at
> /home/ubuntu/Impala/be/src/runtime/query-state.cc:341
> #13 0x0000000001ca2479 in
> boost::detail::function::void_function_obj_invoker0<impala::QueryState::StartFInstances()::<lambda()>,
> void>::invoke(boost::detail::function::function_buffer &)
> (function_obj_ptr=...)
> at
> /home/ubuntu/Impala/toolchain/boost-1.57.0-p3/include/boost/function/function_template.hpp:153
> #14 0x0000000001bd9e58 in boost::function0<void>::operator()() const
> (this=0x7fc7e9029ce0) at
> /home/ubuntu/Impala/toolchain/boost-1.57.0-p3/include/boost/function/function_template.hpp:767
> #15 0x0000000001ec50a9 in impala::Thread::SuperviseThread(std::string const&,
> std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*,
> impala::Promise<long>*) (name="exec-finstance
> (finst:844ac2a49a9a6486:396846db00000005)", category="fragment-execution",
> functor=..., parent_thread_info=0x7fc7ea82c990,
> thread_started=0x7fc7ea82b940) at
> /home/ubuntu/Impala/be/src/util/thread.cc:356
> #16 0x0000000001ecd245 in boost::_bi::list5<boost::_bi::value<std::string>,
> boost::_bi::value<std::string>, boost::_bi::value<boost::function<void ()> >,
> boost::_bi::value<impala::ThreadDebugInfo*>,
> boost::_bi::value<impala::Promise<long>*> >::operator()<void (*)(std::string
> const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo
> const*, impala::Promise<long>*), boost::_bi::list0>(boost::_bi::type<void>,
> void (*&)(std::string const&, std::string const&, boost::function<void ()>,
> impala::ThreadDebugInfo const*, impala::Promise<long>*), boost::_bi::list0&,
> int) (this=0xb84afc0, f=@0xb84afb8: 0x1ec4d42
> <impala::Thread::SuperviseThread(std::string const&, std::string const&,
> boost::function<void ()>, impala::ThreadDebugInfo const*,
> impala::Promise<long>*)>, a=...)
> at
> /home/ubuntu/Impala/toolchain/boost-1.57.0-p3/include/boost/bind/bind.hpp:525
> #17 0x0000000001ecd169 in boost::_bi::bind_t<void, void (*)(std::string
> const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo
> const*, impala::Promise<long>*),
> boost::_bi::list5<boost::_bi::value<std::string>,
> boost::_bi::value<std::string>, boost::_bi::value<boost::function<void ()> >,
> boost::_bi::value<impala::ThreadDebugInfo*>,
> boost::_bi::value<impala::Promise<long>*> > >::operator()() (this=0xb84afb8)
> at
> /home/ubuntu/Impala/toolchain/boost-1.57.0-p3/include/boost/bind/bind_template.hpp:20
> #18 0x0000000001ecd12c in boost::detail::thread_data<boost::_bi::bind_t<void,
> void (*)(std::string const&, std::string const&, boost::function<void ()>,
> impala::ThreadDebugInfo const*, impala::Promise<long>*),
> boost::_bi::list5<boost::_bi::value<std::string>,
> boost::_bi::value<std::string>, boost::_bi::value<boost::function<void ()> >,
> boost::_bi::value<impala::ThreadDebugInfo*>,
> boost::_bi::value<impala::Promise<long>*> > > >::run() (this=0xb84ae00) at
> /home/ubuntu/Impala/toolchain/boost-1.57.0-p3/include/boost/thread/detail/thread.hpp:116
> #19 0x00000000031bc0ea in thread_proxy ()
> #20 0x00007fc8967cc6ba in start_thread (arg=0x7fc7e902a700) at
> pthread_create.c:333
> #21 0x00007fc89650241d in clone () at
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
