[
https://issues.apache.org/jira/browse/IMPALA-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514040#comment-16514040
]
Tim Armstrong commented on IMPALA-7174:
---------------------------------------
-----------
IMPALA-7174: fix test_cancellation for RELEASE builds
The test was DOA when run against a release build because the debug
actions that it depends on were disabled. The fix is to enable the
debug actions for release builds, similar to other debug actions.
I assume the original motivation of the NDEBUG checks was to avoid
adding overhead to release builds. The cost is minimised by quickly
checking whether the string is empty before proceeding with any
further work.
Also remove wonky exception handling - the test was swallowing
exceptions but we don't expect that code to throw exceptions.
Testing:
Looped the test on a release build.
Change-Id: I41da7b5ac58a468a8ed117777969906f63df6d4b
Reviewed-on: [http://gerrit.cloudera.org:8080/10722]
Reviewed-by: Impala Public Jenkins
<[[email protected]|mailto:[email protected]]>
Tested-by: Impala Public Jenkins
<[[email protected]|mailto:[email protected]]>
> TestAdmissionController.test_cancellation failed with incorrect
> total-admitted metric
> -------------------------------------------------------------------------------------
>
> Key: IMPALA-7174
> URL: https://issues.apache.org/jira/browse/IMPALA-7174
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Tianyi Wang
> Assignee: Tim Armstrong
> Priority: Blocker
> Labels: broken-build
> Fix For: Impala 2.13.0, Impala 3.1.0
>
> Attachments:
> impalad.ec2-m2-4xlarge-centos-6-4-01f7.vpc.cloudera.com.jenkins.log.INFO.20180614-060607.2553
>
>
> The failed revision is ee9a9b6c5000cf915716a15ea8a0b3605290a9a5, an
> descendant of 'IMPALA-5216: Make admission control queuing async'.
> {noformat}
> Stacktrace
> custom_cluster/test_admission_controller.py:557: in test_cancellation
> assert self.cluster.impalads[0].service.get_metric_value(
> E assert 0 == 3
> E + where 0 = <bound method ImpaladService.get_metric_value of
> <tests.common.impala_service.ImpaladService object at
> 0x4ed1b90>>('admission-controller.total-admitted.default-pool')
> E + where <bound method ImpaladService.get_metric_value of
> <tests.common.impala_service.ImpaladService object at 0x4ed1b90>> =
> <tests.common.impala_service.ImpaladService object at
> 0x4ed1b90>.get_metric_value
> E + where <tests.common.impala_service.ImpaladService object at
> 0x4ed1b90> = <tests.common.impala_cluster.ImpaladProcess object at
> 0x52474d0>.service
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
