[ 
https://issues.apache.org/jira/browse/IMPALA-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519769#comment-16519769
 ] 

Tim Armstrong commented on IMPALA-6013:
---------------------------------------

So the proposed refactor would be something like?
* Remove ExecEnv from the in-process server, have the test instantiate a TestEnv
* Factor out StartWithEphemeralPorts() into a helper that instantiates a 
regular ImpalaServer in the right way
* Use ImpalaServer directly in tests.

> Remove InProcessImpalaServer
> ----------------------------
>
>                 Key: IMPALA-6013
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6013
>             Project: IMPALA
>          Issue Type: Task
>          Components: Backend
>            Reporter: Sailesh Mukil
>            Assignee: Sailesh Mukil
>            Priority: Major
>              Labels: refactor
>
> Now that we've refactored CreateImpalaServer() such that it can be used in 
> tests (IMPALA-4786), we should get rid of InProcessImpalaServer, which was 
> only historically there because the ImpalaServer couldn't be used in tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to