[ 
https://issues.apache.org/jira/browse/IMPALA-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532117#comment-16532117
 ] 

ASF subversion and git services commented on IMPALA-7237:
---------------------------------------------------------

Commit 83448f1c41d3f73ce0c0174c1725c78af3afd0d0 in impala's branch 
refs/heads/master from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=83448f1 ]

IMPALA-7237: handle hex digits in ParseSmaps()

Testing:
Manual. Added some temporary logging to print out which branch it took
with each line and confirmed it took the right branch for a line
starting with 'f'.

Change-Id: I3dad846dafb25b414bee1858eb63f3eda31d59ac
Reviewed-on: http://gerrit.cloudera.org:8080/10853
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Parsing bug in ParseSMaps()
> ---------------------------
>
>                 Key: IMPALA-7237
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7237
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.10.0, Impala 2.11.0, Impala 3.0, Impala 2.12.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>              Labels: resource-management
>
> The code uses isdigit() but lower-case a-f (i.e. hex digits) can also be 
> present.
> {code}
>     if (isdigit(line[0])) {
>       // Line is the start of a new mapping, of form:
>       // 561ceff9c000-561ceffa1000 rw-p 00000000 00:00 0
>       ++result.num_maps;
>       continue;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to