[
https://issues.apache.org/jira/browse/IMPALA-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553399#comment-16553399
]
Michael Ho commented on IMPALA-7338:
------------------------------------
While things may change once IMPALA-3207 is fixed, some of the ideas still
apply after we support codegen for CHAR type.
> Test coverage for codegen with CHAR type
> ----------------------------------------
>
> Key: IMPALA-7338
> URL: https://issues.apache.org/jira/browse/IMPALA-7338
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 3.0, Impala 2.12.0
> Reporter: Michael Ho
> Assignee: Bikramjeet Vig
> Priority: Major
> Labels: codegen
>
> Until IMPALA-3207 is fixed, we will disable codegen for operators if CHAR is
> involved. Our test coverage for these cases is not very comprehensive. For
> instance, we still hit cases such as IMPALA-7032, IMPALA-7288. This Jira aims
> to track the effort to boost the test coverage for these cases.
> Some ideas:
> * augment existing test cases to make sure we cover all built-in expressions
> which can take char type as argument or return type. This should help catch
> cases such as IMPALA-7032
> * exercise the bail out path in codegen functions (e.g. hash tables, exec
> nodes, expressions) by injecting faults in expression codegen functions to
> fail codegen. This should help catch cases such as IMPALA-7288.
> * Make sure our query generator will generate all possible combination of
> built-in expressions (with CHAR type) and all exec nodes which may codegen.
> cc'ing [~mikesbrown] for query generator idea
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
