[
https://issues.apache.org/jira/browse/IMPALA-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566158#comment-16566158
]
ASF subversion and git services commented on IMPALA-7317:
---------------------------------------------------------
Commit 87b02e7332fd4d74ec09aa7270f242afb92ed36c in impala's branch
refs/heads/master from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=87b02e7 ]
IMPALA-7317: loosen flake8 rules
I got feedback that the flake8 rules are a little too strict, so based
on the [email protected] discussion am disabling some of them.
I left E302 "expected 2 blank lines, found 1" enabled since I think it
would force our formatting to be more consistent, but I'm open to
changing that.
I used the following command to get a sense of the number of existing
violations:
EXCLUDES=ext-py,shell/build,gerrit_critic_venv,infra/python/env
EXCLUDES+=,shell/pkg_resources.py,shell/thrift_sasl.py,gen-py
EXCLUDES+=,TPC-DS-master,toolchain
./bin/impala-flake8 --exclude=${EXCLUDES}
Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997
Reviewed-on: http://gerrit.cloudera.org:8080/11102
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Tim Armstrong <[email protected]>
> Instant validation job that runs on Gerrit upload (clang tidy, other simple
> checks)
> -----------------------------------------------------------------------------------
>
> Key: IMPALA-7317
> URL: https://issues.apache.org/jira/browse/IMPALA-7317
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Fix For: Impala 3.1.0
>
>
> Add a new job to jenkins.impala.io that runs clang tidy upon upload to
> Gerrit. The goal is to prefetch any obvious failures that will prevent the
> code being merged.
> Existing checks that are reasonably cheap:
> * clang-tidy-ub1604
> * ubuntu-16.04-build-only
> * rat-check-ub1604
> Look into other checks to add (flake8, lines too long, etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
