[ 
https://issues.apache.org/jira/browse/IMPALA-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570985#comment-16570985
 ] 

ASF subversion and git services commented on IMPALA-7242:
---------------------------------------------------------

Commit df3f1658461553a174dd27fce2edce8594aefd16 in impala's branch 
refs/heads/master from aphadke
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=df3f165 ]

IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to 
DecimalValue

This change adds a check for an overflow which can happen during
converting num_buckets from IntVal to a DecimalValue during width_bucket
evaluation. An overflow can result in hitting a DCHECK if it needs int256
for intermediate evaluations or returns a wrong result otherwise.

Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60
Reviewed-on: http://gerrit.cloudera.org:8080/11020
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Dcheck fails in width_bucket() function
> ---------------------------------------
>
>                 Key: IMPALA-7242
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7242
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 3.1.0
>            Reporter: Taras Bobrovytsky
>            Assignee: Anuj Phadke
>            Priority: Critical
>
> The following query hits a DCHECK:
> {code:java}
> select width_bucket(cast(-0.10 as decimal(37,30)), cast(-0.36028797018963968 
> as decimal(25,25)), cast(9151517.4969773200562764155787276999832 as 
> decimal(38,31)), 1328180220){code}
> Failed check:
> {code:java}
> math-functions-ir.cc:566] Check failed: overflow == false (1 vs. 0){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to