[
https://issues.apache.org/jira/browse/IMPALA-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581626#comment-16581626
]
ASF subversion and git services commented on IMPALA-7364:
---------------------------------------------------------
Commit efb82325feefd709da1c2c762ee2faae109bdce8 in impala's branch
refs/heads/master from stiga-huang
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=efb8232 ]
IMPALA-7364: Bump RapidJSON version to 1.1.0
There're three kinds of broken APIs to fix:
* Document::AddMember can't accept parameters in const char* types. These
parameters should be wrapped with rapidjson::StringRef().
* Document::GetParseError now returns ParseErrorCode instead of a string.
We should wrap it with GetParseError_En(). The error messages are also
changed. Strings in unit tests should be changed correspondingly.
* rapidjson::FileStream is replaced by rapidjson::FileReadStream
Tests:
* Pass all existing tests
Change-Id: I21353b0d769f81c13f506737e41fbac17655245c
Reviewed-on: http://gerrit.cloudera.org:8080/11124
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Upgrade RapidJson to the latest version
> ---------------------------------------
>
> Key: IMPALA-7364
> URL: https://issues.apache.org/jira/browse/IMPALA-7364
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
>
> Currently, we're using rapidjson-0.11. It's old enough and can't show
> detailed parse errors. In the implementation of built-in JSON function in
> IMPALA-376, we can't show warnings on how we fail to parse a json string and
> where is the error location like this:
> http://rapidjson.org/group___r_a_p_i_d_j_s_o_n___e_r_r_o_r_s.html#structrapidjson_1_1_parse_result
> This JIRA aim to upgrade the version of RapidJson to v1.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
