[
https://issues.apache.org/jira/browse/IMPALA-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668898#comment-16668898
]
Sahil Takiar commented on IMPALA-7780:
--------------------------------------
+1 to some type of long term solution to this. When modifying Planner tests
there seems to be a lot of manual work involved to updating the {{.test}}
files. Either (1) you can make the changes manually, or (2) you can run the
tests and copy the files from {{$IMPALA_FE_TEST_LOGS_DIR/PlannerTest}}
(however, if you do this you hit the issue describe in the JIRA description).
Unless I'm missing an easier way to re-generate planner tests?
If the file sizes are already ignored during the diff operation, it would be
nice to just mask them. This is what Hive does. It replaces certain patterns
with {{#### A masked pattern was here ####}}. The target patterns are usually
strings that can change depending on the test environment (e.g. a HDFS path, or
in this case file sizes).
> Rebase PlannerTest expected output for estimates, errors
> --------------------------------------------------------
>
> Key: IMPALA-7780
> URL: https://issues.apache.org/jira/browse/IMPALA-7780
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Affects Versions: Impala 3.0
> Reporter: Paul Rogers
> Priority: Trivial
>
> The front-end includes the {{PlannerTest}} test which works by running a
> query, writing the plan to a file, comparing selected parts of the file to
> expected results, and flagging if the results differ.
> A plan includes some things we test (operators) and some we do not (text of
> error messages, value of memory estimates). Over time the expected and actual
> files have drifted apart. Example:
> {noformat}
> Expected: partitions=1/1 files=2 size=54.20MB
> Actual: partitions=1/1 files=2 size=54.21MB
> {noformat}
> While the tests still pass (because we ignore the parts which have drifted),
> it is a pain to track down issues because we must learn to manually ignore
> "unimportant" differences.
> This ticket asks to "rebase" planner tests on the latest results, copying
> into the expected results file the current "noise" values from the actual
> results.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
