[
https://issues.apache.org/jira/browse/IMPALA-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong updated IMPALA-4313:
----------------------------------
Issue Type: Improvement (was: Bug)
> Make sure that all binaries we produce contain a .note.gnu.build-id section
> ---------------------------------------------------------------------------
>
> Key: IMPALA-4313
> URL: https://issues.apache.org/jira/browse/IMPALA-4313
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 2.7.0
> Reporter: Lars Volker
> Priority: Major
> Labels: breakpad, infra, ramp-up, supportability
>
> Breakpad uses {{.note.gnu.build-id}} to identify binaries and falls back to
> hashing the first page of the text section.
> [src/common/linux/file_id.cc#148|https://chromium.googlesource.com/breakpad/breakpad/+/master/src/common/linux/file_id.cc#148]
> {code}
> bool FileID::ElfFileIdentifierFromMappedFile(const void* base,
> wasteful_vector<uint8_t>&
> identifier) {
> // Look for a build id note first.
> if (FindElfBuildIDNote(base, identifier))
> return true;
> // Fall back on hashing the first page of the text section.
> return HashElfTextSection(base, identifier);
> }
> {code}
> The latter can lead to collisions on large binaries like impalad. Therefore
> we should make sure we have {{.note.gnu.build-id}} in all binaries. More
> information can be found here:
> https://fedoraproject.org/wiki/Releases/FeatureBuildId
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
