[ 
https://issues.apache.org/jira/browse/IMPALA-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Armstrong updated IMPALA-6656:
----------------------------------
    Description: 
We should track the total time spent and the time spent in TCMalloc so we can 
understand where time is going globally. 

I think we should shard them by CurrentCore() to avoid contention and get more 
granular metrics. We want a timer for the amount of time spent in 
SystemAllocator. We probably also want counters for how many times we go down 
each code path in BufferAllocator::AllocateInternal() (i.e. getting a hit 
immediately in the local area, evicting a clean page, etc down to doing a full 
locked scavenge).

  was:
We should track the total time spent and the time spent in TCMalloc so we can 
understand where time is going globally. 

I think we should shard these metrics across the arenas so we can see if the 
problem is just per-arena, and also to avoid contention between threads when 
updating the metrics.


> Metrics for time spent in BufferAllocator
> -----------------------------------------
>
>                 Key: IMPALA-6656
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6656
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>              Labels: observability, resource-management
>
> We should track the total time spent and the time spent in TCMalloc so we can 
> understand where time is going globally. 
> I think we should shard them by CurrentCore() to avoid contention and get 
> more granular metrics. We want a timer for the amount of time spent in 
> SystemAllocator. We probably also want counters for how many times we go down 
> each code path in BufferAllocator::AllocateInternal() (i.e. getting a hit 
> immediately in the local area, evicting a clean page, etc down to doing a 
> full locked scavenge).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to