[
https://issues.apache.org/jira/browse/IMPALA-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692033#comment-16692033
]
ASF subversion and git services commented on IMPALA-5031:
---------------------------------------------------------
Commit 53ce6bb571cd9ae07ba5255197d35aa852a6f97c in impala's branch
refs/heads/master from [~jbapple]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=53ce6bb ]
IMPALA-5031: signed overflow is undefined behavior
This patch fixes a signed overflow in the backend test
DecimalTest.Overflow. The interesting part of the backtrace is:
runtime/decimal-value.inline.h:254:17: runtime error: signed integer
overflow: 0x4b3b4ca85a86c47a098a223fffffffff +
0x4b3b4ca85a86c47a098a223fffffffff cannot be represented in
type '__int128'
#0 detail::AddLarge(__int128, int, __int128, int, int, bool,
bool*) runtime/decimal-value.inline.h:254:17
#1 DecimalValue<__int128> DecimalValue<__int128>::Add<__int128>(
int, DecimalValue<__int128> const&, int, int, int, bool,
bool*) const runtime/decimal-value.inline.h:371:14
#2 DecimalTest_Overflow_Test::TestBody()
runtime/decimal-test.cc:540:9
Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Reviewed-on: http://gerrit.cloudera.org:8080/11917
Reviewed-by: Jim Apple <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> UBSAN clean and method for testing UBSAN cleanliness
> ----------------------------------------------------
>
> Key: IMPALA-5031
> URL: https://issues.apache.org/jira/browse/IMPALA-5031
> Project: IMPALA
> Issue Type: Task
> Components: Backend, Infrastructure
> Affects Versions: Impala 2.9.0
> Reporter: Jim Apple
> Assignee: Jim Apple
> Priority: Minor
>
> http://releases.llvm.org/3.8.0/tools/clang/docs/UndefinedBehaviorSanitizer.html
> builds are supported after https://gerrit.cloudera.org/#/c/6186/, but
> Impala's test suite triggers many errors under UBSAN. Those errors should be
> fixed and then there should be a way to run the test suite under UBSAN and
> fail if there were any errors detected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
