[
https://issues.apache.org/jira/browse/IMPALA-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711775#comment-16711775
]
ASF subversion and git services commented on IMPALA-7842:
---------------------------------------------------------
Commit 7dbeb6950f4d21248dc71b89add1aa14b8c95a8f in impala's branch
refs/heads/master from [~paul-rogers]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=7dbeb69 ]
IMPALA-7842: Expose physical plan for unit testing
The FrontEnd class uses a functional model to generate a plan: pass
in SQL text to the createExecRequest() method and get back a Thrift
plan ready for serialization.
For unit testing, however, we need access to the intermediate physical
plan tree produced by the planner. Inspecting only the Thrift version
results in loss of important details.
This fix introduces a new planner context (PlanCtx) class that passes
information into the planner, and passses the physical plan back out.
Code that used the prior version (pass in a query context and explain
string) are changed to use the new form.
Testing:
* There is no functional change, just a refactoring of the existing
code. Ran all FE test to verify no regressions.
* Introduces a new test case that uses this feature to verify plan
cardinality.
Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d
Reviewed-on: http://gerrit.cloudera.org:8080/11920
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Refactor FrontEnd to make plan fragments available for testing
> --------------------------------------------------------------
>
> Key: IMPALA-7842
> URL: https://issues.apache.org/jira/browse/IMPALA-7842
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Affects Versions: Impala 3.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
>
> Today, the {{FrontEnd}} class uses a functional model to generate a plan:
> pass in SQL text to the {{createExecRequest()}} method and get back a Thrift
> plan ready for serialization.
> For unit testing, however, we need access to the intermediate plan fragments
> produced by the planner. Inspecting only the Thrift version results in loss
> of important details.
> This ticket asks to create a new {{PlanCtx}} which can capture the details
> for testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
