[
https://issues.apache.org/jira/browse/IMPALA-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720166#comment-16720166
]
ASF subversion and git services commented on IMPALA-7926:
---------------------------------------------------------
Commit 1cbcd0c37d47b1b22780a788e59f0f3e67d2a626 in impala's branch
refs/heads/master from [~twmarshall]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=1cbcd0c ]
IMPALA-7926: Fix flakiness in test_reconnect
test_reconnect launches a shell that connects to one impalad in the
minicluster then reconnects to a different impalad while checking that
the impalad's open session metric changes accordingly.
To do this, the test gets the number of open sessions at the start of
the test and then expects that the number of sessions will have
increased by 1 on the impalad that the shell is currently connected
to.
This can be a problem if there is a session left over from another
test that is still active when test_reconnect starts but exits while
it's running.
test_reconnect is already marked to run serially, so there shouldn't
be any other sessions open while it runs anyways. The solution is to
wait at the start of the test until any sessions left over from other
tests have exited.
Testing:
- Ran the test in an environment where the timing was previously
causing it to fail almost deterministically and it now passes.
Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434
Reviewed-on: http://gerrit.cloudera.org:8080/12045
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_reconnect failing
> ----------------------
>
> Key: IMPALA-7926
> URL: https://issues.apache.org/jira/browse/IMPALA-7926
> Project: IMPALA
> Issue Type: Bug
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
> Labels: broken-build
>
> {noformat}
> 00:52:58 __________________ TestImpalaShellInteractive.test_reconnect
> ___________________
> 00:52:58 shell/test_shell_interactive.py:191: in test_reconnect
> 00:52:58 assert get_num_open_sessions(initial_impala_service) ==
> num_sessions_initial, \
> 00:52:58 E AssertionError: Connection to localhost.localdomain:21000 should
> have been closed
> 00:52:58 E assert 0 == 1
> 00:52:58 E + where 0 = <function get_num_open_sessions at
> 0xccdf848>(<tests.common.impala_service.ImpaladService object at 0xccd6b10>)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
