[
https://issues.apache.org/jira/browse/IMPALA-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724345#comment-16724345
]
ASF subversion and git services commented on IMPALA-7963:
---------------------------------------------------------
Commit 4ea5c9b977552cc3e927116328aa50051d447bc3 in impala's branch
refs/heads/master from Joe McDonnell
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=4ea5c9b ]
IMPALA-7963: Don't underflow uint64_t when time goes backwards
Some tests on Centos 6 have shown small backwards time drifts.
In this case, MonotonicStopWatch currently underflows a uint64_t
and returns a very large value from RunningTime(). This changes
RunningTime() to log a warning and return 0 when end < start_.
Something about this changed Clang Tidy's view of the world,
leading it to complain about division by zero at
pretty-printer.h#L87. Switching some debug statment in webserver
from using CPU_TICKS to TIME_NS fixes this issue. It is also
the correct thing to do.
Change-Id: Ifa2abbbabe340b3c5f1dbec613219bc964f15747
Reviewed-on: http://gerrit.cloudera.org:8080/12091
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
> test_empty_build_joins failed with hdfs timeout
> -----------------------------------------------
>
> Key: IMPALA-7963
> URL: https://issues.apache.org/jira/browse/IMPALA-7963
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.2.0
> Reporter: Thomas Tauber-Marshall
> Assignee: Joe McDonnell
> Priority: Blocker
> Labels: broken-build, flaky
>
> Seen in an exhaustive build on centos6:
> {noformat}
> 05:39:09 TestJoinQueries.test_empty_build_joins[batch_size: 1 | protocol:
> beeswax | exec_option: {'batch_size': 0, 'num_nodes': 0,
> 'disable_codegen_rows_threshold': 0, 'disable_codegen': False,
> 'abort_on_error': 1, 'debug_action': None, 'exec_single_node_rows_threshold':
> 0} | table_format: parquet/none]
> 05:39:09 [gw3] linux2 -- Python 2.6.6
> /data/jenkins/workspace/impala-asf-master-exhaustive-centos6/repos/Impala/bin/../infra/python/env/bin/python
> 05:39:09 query_test/test_join_queries.py:97: in test_empty_build_joins
> 05:39:09 self.run_test_case('QueryTest/empty-build-joins', new_vector)
> 05:39:09 common/impala_test_suite.py:467: in run_test_case
> 05:39:09 result = self.__execute_query(target_impalad_client, query,
> user=user)
> 05:39:09 common/impala_test_suite.py:688: in __execute_query
> 05:39:09 return impalad_client.execute(query, user=user)
> 05:39:09 common/impala_connection.py:170: in execute
> 05:39:09 return self.__beeswax_client.execute(sql_stmt, user=user)
> 05:39:09 beeswax/impala_beeswax.py:182: in execute
> 05:39:09 handle = self.__execute_query(query_string.strip(), user=user)
> 05:39:09 beeswax/impala_beeswax.py:359: in __execute_query
> 05:39:09 self.wait_for_finished(handle)
> 05:39:09 beeswax/impala_beeswax.py:380: in wait_for_finished
> 05:39:09 raise ImpalaBeeswaxException("Query aborted:" + error_log, None)
> 05:39:09 E ImpalaBeeswaxException: ImpalaBeeswaxException:
> 05:39:09 E Query aborted:hdfsOpenFile() for
> hdfs://localhost:20500/test-warehouse/alltypestiny/year=2009/month=2/090201.txt
> failed to finish before the 300 second timeout
> 05:39:09 ----------------------------- Captured stderr call
> -----------------------------
> 05:39:09 -- executing against localhost:21000
> 05:39:09 use functional_parquet;
> 05:39:09
> 05:39:09 -- 2018-12-11 03:11:34,797 INFO MainThread: Started query
> d747763f9d663cd7:9abd4b9900000000
> 05:39:09 SET batch_size=1;
> 05:39:09 SET num_nodes=0;
> 05:39:09 SET disable_codegen_rows_threshold=0;
> 05:39:09 SET disable_codegen=False;
> 05:39:09 SET abort_on_error=1;
> 05:39:09 SET exec_single_node_rows_threshold=0;
> 05:39:09 -- executing against localhost:21000
> 05:39:09 select straight_join atp.id
> 05:39:09 from alltypes atp
> 05:39:09 inner join functional.alltypestiny att on atp.id = att.id
> 05:39:09 where att.int_col = 999;
> 05:39:09
> 05:39:09 -- 2018-12-11 03:11:34,816 INFO MainThread: Started query
> 5045de8553c5843c:bdc6aa1c00000000
> 05:39:09 -- executing against localhost:21000
> 05:39:09 select straight_join atp.id
> 05:39:09 from alltypes atp
> 05:39:09 right join functional.alltypestiny att on atp.id = att.id
> 05:39:09 where att.int_col = 999;
> 05:39:09
> 05:39:09 -- 2018-12-11 03:11:35,519 INFO MainThread: Started query
> 124ef451a3f65d09:f2ae4a5d00000000
> {noformat}
> Presumably caused by IMPALA-7738
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
