Andrew Sherman created IMPALA-8047:
--------------------------------------
Summary: Add support for the .proto file extension to
.clang-format
Key: IMPALA-8047
URL: https://issues.apache.org/jira/browse/IMPALA-8047
Project: IMPALA
Issue Type: Improvement
Reporter: Andrew Sherman
The .proto file extension is used for the Google Protocol Buffers language.
Impala uses this language to specify the format of messages used by KRPC. Add
support for this language to .clang-format so that we can have consistent
formatting.
The proposed support is:
{{Language: Proto
BasedOnStyle: Google
ColumnLimit: 90}}
This produces only a few diffs when run against the existing Impala code. I’m
not proposing to make any changes to .proto files, this is just to show what
clang-format will do. Apart from wrapping comments and code at 90 chars, the
diffs are mostly of the form
{{-syntax="proto2";
+syntax = "proto2";}}
{{- message Certificate {};
+ message Certificate {
+ };}}
{{- optional bool client_timeout_defined = 4 [ default = false ];
+ optional bool client_timeout_defined = 4 [default = false];}}
{{- UNKNOWN = 999;
- NEGOTIATE = 1;
- SASL_SUCCESS = 0;
- SASL_INITIATE = 2;
+ UNKNOWN = 999;
+ NEGOTIATE = 1;
+ SASL_SUCCESS = 0;
+ SASL_INITIATE = 2;}}
This last change can be configured using “AlignConsecutiveAssignments: true”
but that creates a different set of diffs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
